Add oidc configuration

[71g3pf4c3]

Added oidc configuration in helm chart. User can provide existing client secret or insert it explicitly in values.
All configuration specified will be merged with configureUserSettings json and passed to CONFIG_OVERWRITE_JSON variable.
Additionally json merge provides validation of configureUserSettings, preventing passing invalid json into it.

[reasonerjt]

It was a decision not to expose authentication settings in values.yaml, b/c this is considered "day-2" settings, that admin will handle it after Harbor is installed.

Similarly, we chose not to enable user to setup LDAP in values.yaml, such configuration can only be made by providing a JSON string in "configureUserSettings"

[71g3pf4c3]

It was a decision not to expose authentication settings in values.yaml, b/c this is considered "day-2" settings, that admin will handle it after Harbor is installed.

Similarly, we chose not to enable user to setup LDAP in values.yaml, such configuration can only be made by providing a JSON string in "configureUserSettings"

This feature can be helpful with fully automated deployments and gitops environments like flux. I also added functionality to use exitsting incluster secret values.
configureUserSettings provides very limited range of configuration with just plain string field and without json validation or any validation at all, so i think my solution can be more convenient way to configure.

[71g3pf4c3]

@reasonerjt please consider this feature, it helps in automated deployments regularly

[Vad1mo]

It was a decision not to expose authentication settings in values.yaml, b/c this is considered "day-2" settings, that admin will handle it after Harbor is installed.

Similarly, we chose not to enable user to setup LDAP in values.yaml, such configuration can only be made by providing a JSON string in "configureUserSettings"

Not so long ago, CONFIG_OVERWRITE_JSON was introduced, to support upfront Harbor configuration.
It is not clear to me or to Harbor users why CONFIG_OVERWRITE_JSON should be a day-2 operation?
Users are not using CONFIG_OVERWRITE_JSON for day-2, only for day-1 or to be precise for the initial setup.

IMO it is also difficult to justify why 90% of harbor users, who install harbor via Helm Chats should not be able to use this feature,

[lknite]

OIDC configuration is not daytwo in the world of gitops ... the only reason one would think that is if they are not using argocd/flux/kapp ... I most humbly wish to plant the seed that folks may wish to give argocd a try as you will definately like it, definitely start using it, and then you will definitely want to update the helm charts to work in a gitops manner... and you will love it... there's no question it is the right direction.

This used to be in the helm chart in a comment:

  core:
    extraEnvVars:
    - name: CONFIG_OVERWRITE_JSON
      value: |
        {
          "auth_mode": "oidc_auth",
          "oidc_name": "keycloak",
          "oidc_endpoint": "https://keycloak.vc-prod.k.home.net/realms/home",
          "oidc_groups_claim": "groups",
          "oidc_admin_group": "vc-prod-app-harbor-admin",
          "oidc_client_id": "defaultwithsecret",
          "oidc_client_secret": "<redacted>",
          "oidc_scope": "openid,email,profile,offline_access",
          "oidc_verify_cert": "false",
          "oidc_auto_onboard": "true",
          "oidc_user_claim": "preferred_username"
        }

[71g3pf4c3]

@Vad1mo fixed unit test for trimmed json. Helm trims all the whitespace and line breaks, so it breaks tests