Support existing secret for external DB

[cest-pas-faux]

Hi,

This PR adds the ability to specify an existing secret for all the DB configurations (host, port, user, password, coreDatabase).

Tests done with this updated chart :

• Reference an existing secret and setting existingSecret.enabled: true
• Hardcode the connection configuration values under external and set existingSecret.enabled: false

Both tests are successful, pull/push images OK.

[MinerYang]

Hi @cest-pas-faux ,

I don't think these settings expect password need to be mounted as secret, configmap is enough for them.
And it will better align with our other values conventions

Best,
Miner

[cest-pas-faux]

Hi @MinerYang, thanks for this review

The password stored as secret is the current behavior and has not been introduced by me, see templates below :

• https://github.com/goharbor/harbor-helm/blob/main/templates/core/core-dpl.yaml#L130
• https://github.com/goharbor/harbor-helm/blob/main/templates/database/database-secret.yaml
• https://github.com/goharbor/harbor-helm/blob/main/templates/core/core-secret.yaml#L25

I didn't want to create a breaking change by removing this secret which is shared by different components.
How to you want me to proceed ?

[cest-pas-faux]

Hi @MinerYang , any updates on this ?

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[cest-pas-faux]

Hi @MinerYang , just a heads up :)

[cest-pas-faux]

/remove-lifecycle stale

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[cest-pas-faux]

/remove-lifecycle stale

[cest-pas-faux]

Hi @MinerYang , did you have any time to look into this PR ?