[Core,Drivers] Improve use of Ref.is_null/valid
#96076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that using "positive" boolean math is better, but I don't know why we're doing this. Is there a bug or issue relating to this by the general godot engine community? |
|
This is simply for conformity and clarity of code |
Mickeon
reviewed
Aug 26, 2024
AThousandShips
force-pushed
the
improve_null_check_core_drivers
branch
from
0f87090 to
f6ebb12
Compare
Mickeon
approved these changes
Aug 27, 2024
AThousandShips
force-pushed
the
improve_null_check_core_drivers
branch
from
f6ebb12 to
cd33444
Compare
AThousandShips
force-pushed
the
improve_null_check_core_drivers
branch
from
cd33444 to
cdea2db
Compare
AThousandShips
force-pushed
the
improve_null_check_core_drivers
branch
from
cdea2db to
bf402da
Compare
Use `is_null` over `!is_valid` and vice versa.
AThousandShips
force-pushed
the
improve_null_check_core_drivers
branch
from
bf402da to
ec650a2
Compare
fire
approved these changes
Nov 1, 2024
Repiteo
approved these changes
Dec 23, 2024
|
Haven't gone back over these to ensure no new ones have cropped up but I tend to keep an eye on reviews so there shouldn't be anything missing |
|
I'll operate under the assumption that it's accurate; future tweaks likely won't need to be sectioned off like this anyway |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
is_nullover!is_validand vice versa.Split into parts for easier review.