-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uid://
paths fail to load at editor startup
#95689
Fix uid://
paths fail to load at editor startup
#95689
Conversation
uid://
paths fail to load at editor startup
Might also solve #95535 which may be a duplicate of the other issue, CC @TheDuriel. |
Indeed, I tested this PR with the MRP from #95535 (comment) and the issue is fixed. Same here, the first time loading the project, I got the errors and restarting the editor fixes them. |
Will gladly test if someone can provide a windows build. Still suffering build errors on my end. |
@TheDuriel Click on summary link on the left: At the bottom you have all the artifacts: For windows: |
Awesome. Can confirm then, this PR fixes all my errors, including ones not caused by autoloads. |
Looks good from my standpoint on #95562 as well. Thanks for taking the time to fix this 😄 |
Thanks! |
Cherry-picked for 4.3.1. |
The issue was caused by a call deferred to
ResourceUID::get_singleton()->clear
in the constructor ofEditorFileSystem
. Now that the plugin are created after the creation ofEditorFileSystem
the uid loaded from cache were removed before the plugins were created in the first scan process.Note: Even in 4.2.2 when the uid cache file
uid_cache.bin
is missing, the same error occurs:Condition "!unique_ids.has(p_id)" is true
because the uid are loaded only from the cache before the plugins are created. The same problem still occurs with this PR and short of scanning all the .import files before loading the plugins just for the uid, I don't see an solution for that.Edit: Added the issue #95535