-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use minor version in EditorSettings file name #90875
Conversation
While it will migrate settings from older versions, the settings are independent for each minor version after the migration. If I change the editor settings in a new version (e.g., 4.4), the older (4.3) will still need to change again. Is it possible to share the same |
It's possible, but I explained why it's better to not do that. Even before format change I had settings disappearing when downgrading and eventually I started running every version in self-contained mode. I don't see how it's desirable. |
Not really, from 4.0 to 4.3.dev5, almost all editor settings are retained when downgrading, except for those newly added properties. That's why I want them to share the same one. |
4.2 -> 4.3 for example changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I agree with this approach, we've had a few issues due to reusing the same file across minor releases, and this will grow as the 4.x series keeps getting more and more features.
Thanks! |
When switching between different Godot minor versions, due to shifting defaults or changing shortcuts, there is a risk of losing data saved in editor settings. The most prominent case is the newest format change in 4.3, which causes the settings file to be "corrupted" in older versions, resulting in complete reset.
This PR adds a minor version to settings name, so now it's
editor_settings-4.3.tres
and so on. When opening new version for the first time, the editor will automatically search for older settings and migrate them.Bugsquad edit: