Fix multiline array/dictionary match statements #90373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Please add test cases for this. |
akien-mga
changed the title
bitwise-aiden
force-pushed
the
ba-fix-mutliline-match
branch
from
580e3d9 to
847d708
Compare
bitwise-aiden
commented
Apr 8, 2024
bitwise-aiden
force-pushed
the
ba-fix-mutliline-match
branch
from
847d708 to
85d5feb
Compare
I believe this is good to go, let me know if there is anything else you're after. |
dalexeev
reviewed
Apr 10, 2024
|
Please squash commits into one. To do this you need a local git client, GitHub web interface doesn't support it. |
bitwise-aiden
force-pushed
the
ba-fix-mutliline-match
branch
from
35ab7b7 to
f989f79
Compare
dalexeev
approved these changes
Apr 10, 2024
bitwise-aiden
force-pushed
the
ba-fix-mutliline-match
branch
from
f989f79 to
0b05e5b
Compare
akien-mga
force-pushed
the
ba-fix-mutliline-match
branch
from
0b05e5b to
1aee33a
Compare
Currently array and dictionary expressions cannot be spread over multiple lines in match statements. Adding mutliline push/pop while parsing the pattern for bracket and brace enables the ability for these to be multiline. This enables more complex patterns to be matched without exceeding line limits. Fixes godotengine#90372
akien-mga
force-pushed
the
ba-fix-mutliline-match
branch
from
1aee33a to
74177d7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently array and dictionary expressions cannot be spread over multiple lines in match statements.
Adding mutliline push/pop while parsing the pattern for bracket and brace enables the ability for these to be multiline. This enables more complex patterns to be matched without exceeding line limits.
Fixes #90372