Fix concave CollisionPolygon2D debug drawing and docs
#89820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The empty inside would be consistent with |
KoBeWi
approved these changes
Mar 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug drawing for
CollisionPolygon2Dshowed the convex decomposition unconditionally, which was meaningless in Segments build mode. The dead code would show a filled polygon, which would also be misleading as you can just as well put a character on the inside (because the shape is purely built of segments), so this PR draws nothing on the inside when the build mode is Segments. (If people do prefer a filled polygon, we could do that instead.)collisionpolygon2d-debug.mp4
The documentation had some copy/paste error from the 3D analogue, and it was mentioning only the solid option; now hollow is mentioned as well.