Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of XMLParser::get_node_name() #89141

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix documentation of XMLParser::get_node_name() #89141

merged 1 commit into from
Mar 4, 2024

Conversation

timothyqiu
Copy link
Member

Closes #89120

The described condition for error was wrong.

Also adds a note for the unintuitive API name.

@timothyqiu timothyqiu added this to the 4.3 milestone Mar 4, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner March 4, 2024 13:04
Mickeon
Mickeon approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me feels like that "Are also considered names" part should be included in the constants themselves, but this looks fine.

@akien-mga akien-mga merged commit b6382a5 into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the xml-node-name branch April 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CDATA nodes' content can only be retrieved using XMLParser.get_node_name().
3 participants
@timothyqiu @akien-mga @Mickeon