Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto translation to Tree #89032

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add auto translation to Tree #89032

merged 1 commit into from
Mar 1, 2024

Conversation

YeldhamDev
Copy link
Member

Should fully close #80549.

@YeldhamDev YeldhamDev added this to the 4.3 milestone Mar 1, 2024
@YeldhamDev YeldhamDev requested a review from a team as a code owner March 1, 2024 04:33
akien-mga
akien-mga reviewed Mar 1, 2024
View reviewed changes
scene/gui/tree.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Mar 1, 2024
View reviewed changes
scene/gui/tree.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test every cell mode, but the base functionality is working correctly.
I was surprised that it doesn't cause any unwanted translations in the editor, even with non-editable Trees 🤔

@YeldhamDev
Copy link
Member Author

YeldhamDev commented Mar 1, 2024 •
edited
Loading

Changes made.

Huh... I pushed the changes, but the PR itself isn't updating for some reason?

@YeldhamDev YeldhamDev force-pushed the as_arvores_somos_nozes branch 2 times, most recently from 0aad4d3 to 612eed1 Compare March 1, 2024 15:38
@akien-mga akien-mga merged commit c10463f into godotengine:master Mar 1, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the as_arvores_somos_nozes branch March 1, 2024 16:56
@KoBeWi
Copy link
Member

KoBeWi commented Mar 15, 2024

I was surprised that it doesn't cause any unwanted translations in the editor, even with non-editable Trees

Apparently it auto-translates file names in FileSystem.

godot_YbWYtzAqyB.mp4

@YeldhamDev YeldhamDev mentioned this pull request Mar 16, 2024
Merged
@timothyqiu timothyqiu mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Some Control Type not auto translate when enable auto_translate
3 participants
@YeldhamDev @akien-mga @KoBeWi