Fix Animation Bezier Editor key selection bugs #88459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookieBadger
force-pushed
the
animation-bezier-selection-fixes
branch
from
8f20a3c to
0fe9d5f
Compare
|
rebased on top of 5f05e2b |
akien-mga
reviewed
Feb 20, 2024
CookieBadger
force-pushed
the
animation-bezier-selection-fixes
branch
from
0fe9d5f to
080315c
Compare
|
rebased on top of b714563 |
akien-mga
approved these changes
Feb 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugs fixes a regression introduced with #87250, which resulted in not being able to move multiple keys in Bezier editor at once anymore. It re-adds the accidentally removed delete shortcut and the cut shortcut, which interestingly kept working, as the shortcuts were still covered by the AnimationTrackEditor, but I thought to be safe they should be put back. Finally, this PR also fixes an old bug that snapped keys in the Bezier editor upon selection, which is not desirable, by adding a check if the mouse has been moved or not.