Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first interaction action to better inform newcomers #88137

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Feb 9, 2024

Creates a first interaction action.

https://github.com/actions/first-interaction

  • Add the first issue message.
  • Add the first PR message.
  • Ask the comms team input for the messages

@adamscott adamscott force-pushed the first-interaction-action branch from 4f3e920 to f2fcf37 Compare February 9, 2024 13:40
@adamscott adamscott force-pushed the first-interaction-action branch 3 times, most recently from f3cbbf9 to 25d6086 Compare February 9, 2024 16:11
@fire
Copy link
Member

fire commented Feb 9, 2024

I think this is a great idea and will like this to be implemented. Github knows when a contributor is new and we can use this information to give more detailed instructions.

@adamscott adamscott force-pushed the first-interaction-action branch 5 times, most recently from cbbf8d5 to 6471e03 Compare February 9, 2024 21:15
@AThousandShips AThousandShips added this to the 4.x milestone Feb 10, 2024
@coppolaemilio
Copy link
Member

The "Be patient." at the end sounds very aggressive. I would go for something like "thank you for your patience" instead 😅

Copy link

@MurderVeggie MurderVeggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for making you wait, here a last few rephrasing suggestions:

if steps or assets -> if **specific** steps or assets
The time it may take -> The time it will take
could vary -> may vary
to see if some fixes have been made -> to track new fixes

And I concur with Emi on Thank you for your patience.

@adamscott adamscott force-pushed the first-interaction-action branch from 6471e03 to 8938844 Compare March 14, 2024 11:25
@adamscott adamscott marked this pull request as ready for review March 14, 2024 11:25
@adamscott adamscott requested a review from a team as a code owner March 14, 2024 11:25
@adamscott
Copy link
Member Author

Done! Thanks @MurderVeggie and @AThousandShips for your reviews. I set the PR as ready, as all changes were implemented.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't tell if anything is missing though, but what's there is great!

.github/workflows/first_interaction.yml Outdated Show resolved Hide resolved
.github/workflows/first_interaction.yml Outdated Show resolved Hide resolved
.github/workflows/first_interaction.yml Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 14, 2024
@adamscott adamscott force-pushed the first-interaction-action branch from 8938844 to 206787c Compare April 4, 2024 12:39
@adamscott adamscott force-pushed the first-interaction-action branch from 206787c to fabd6d8 Compare April 4, 2024 12:42
@akien-mga akien-mga merged commit a1acf0c into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants