Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation to Viewport #86994

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 9, 2024

This PR fills all of the class reference's descriptions that have been missing from Viewport. It also tweaks existing descriptions very slightly.

In particular, the descriptions for sdf_oversize, sdf_scale, snap_2d_transforms_to_pixel, and snap_2d_vertices_to_pixel have almost been copied word-for-word from the equivalent Project Settings.

I could have rewritten them outright, but the time I spend on these is directly proportional to how long it will take for them to be reviewed and merged.

@Mickeon Mickeon requested a review from a team as a code owner January 9, 2024 11:50
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 9, 2024
@Mickeon Mickeon force-pushed the fill-viewport-documentation branch from 22bd225 to 62a42c8 Compare January 9, 2024 11:56
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mickeon This looks good to me, but needs a rebase.

@akien-mga akien-mga force-pushed the fill-viewport-documentation branch from 62a42c8 to 50f6965 Compare April 8, 2024 09:12
@akien-mga akien-mga merged commit 8ec21df into godotengine:master Apr 8, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the fill-viewport-documentation branch April 8, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants