Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note that a large value for Label.outline_size is not recommended #86345

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add note that a large value for Label.outline_size is not recommended #86345

merged 1 commit into from
Dec 22, 2023

Conversation

brno32
Copy link
Contributor

@brno32 brno32 commented Dec 19, 2023

Resolves #54214.

Not sure if we want to go into the technical limitations in this note? Perhaps setting a lower maximum value for this property would also be beneficial.

@brno32 brno32 requested a review from a team as a code owner December 19, 2023 22:16
@AThousandShips AThousandShips changed the title add note that a large value for outline_size is not recommended Add note that a large value for outline_size is not recommended Dec 19, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Dec 19, 2023
@AThousandShips
Copy link
Member

(Commits should start with a capital letter, please update this to match the preferred style 🙂)

@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Dec 19, 2023
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 19, 2023
@AThousandShips AThousandShips changed the title Add note that a large value for outline_size is not recommended Add note that a large value for Label.outline_size is not recommended Dec 19, 2023
AThousandShips
AThousandShips approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and sounds good to me, will also request an area maintainer for an extra look

@AThousandShips AThousandShips requested a review from a team December 19, 2023 22:26
Calinou
Calinou reviewed Dec 20, 2023
View reviewed changes
doc/classes/Label.xml Outdated Show resolved Hide resolved
@brno32 brno32 requested a review from Calinou December 20, 2023 16:50
@YuriSizov YuriSizov merged commit 84d4889 into godotengine:master Dec 22, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@brno32 brno32 deleted the outline-size-docs branch December 22, 2023 16:55
@YuriSizov YuriSizov removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Font Outline gaps won't close up when Outline size is increased
4 participants
@brno32 @AThousandShips @YuriSizov @Calinou