-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X11: Send IME update notification deferred #85306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work! I'm approving this PR, but @bruvzg should have the last word on it.
Isn't this PR meant to workaround the ibus issue? If so it seems good to me to merge this now and cherry-pick for 4.2.1, as we don't know how long it will take for ibus to fix its regression and for Linux distros to pick up the fix. |
No, it doesn't fix the IBus issue. It fixes the fact that the event is coming from a state where it's not thread-safe for nodes. |
I'm still confused, it claims to fix the issues which were pinpointed as caused by the ibus regression. |
Well, it fixes the |
If I understand correctly, this will fix crash with IBus, but not missing dead keys (which is IBus bug). |
Thanks! |
Cherry-picked for 4.2.1. |
Fixes #82338
Fixes #82608
I suggest only merging this once the
ibus
issue is resolved. The error message is not directly linked to the problem with accented characters not inserting, but it will help users who encounter the problem to find the related issue on Github.