Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating delimiter cache of CodeEdit when typing on the first line #85191

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix updating delimiter cache of CodeEdit when typing on the first line #85191

merged 1 commit into from
Dec 20, 2023

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Nov 21, 2023 •
edited
Loading

Fixes: #77726
Fixes: #75774

When typing on the first line of a CodeEdit the delimiter cache would not be updated beyond that line.

@HolonProduction HolonProduction requested a review from a team as a code owner November 21, 2023 21:43
@KoBeWi KoBeWi added this to the 4.3 milestone Nov 21, 2023
Paulb23
Paulb23 reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, would be good to add a unit test to capture this

@HolonProduction HolonProduction requested a review from a team as a code owner December 18, 2023 13:06
@HolonProduction
Copy link
Member Author

Added a unit test

@YuriSizov YuriSizov merged commit 40e7192 into godotengine:master Dec 20, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@HolonProduction HolonProduction deleted the off-by-one-code-edit branch October 5, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Paulb23 approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gui
Projects
None yet
Milestone
4.3
4 participants
@HolonProduction @YuriSizov @Paulb23 @KoBeWi