Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const references in String class #84375

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add const references in String class #84375

merged 1 commit into from
Jan 4, 2024

Conversation

Rubonnek
Copy link
Member

@Rubonnek Rubonnek commented Nov 2, 2023

Using const references against non primitive types is faster. It's only missed in a few places.

@Rubonnek Rubonnek requested a review from a team as a code owner November 2, 2023 17:44
@AThousandShips AThousandShips added this to the 4.2 milestone Nov 2, 2023
@AThousandShips
Copy link
Member

Might be good to specify it's just in String and not all String arguments across the codebase, but should be obvious from the diff

@Rubonnek Rubonnek force-pushed the use-const-reference branch from ccea670 to dbc49d2 Compare November 2, 2023 17:51
@Rubonnek Rubonnek changed the title Use const reference on Strings where possible Add const references in String class Nov 2, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Nov 2, 2023
@darksylinc
Copy link
Contributor

Same comment as in your other PR.

@akien-mga akien-mga merged commit b66d16f into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Rubonnek @AThousandShips @darksylinc @akien-mga @YuriSizov