[3.x] Backport "Add finished signal to GPUParticles"
#81559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
finished signal to GPUParticles" to 3.xfinished signal to GPUParticles"
akien-mga
reviewed
Sep 12, 2023
|
Should have a co-authorship as it's mostly rearranging code, add the following to your commit message: |
matorin57
force-pushed
the
3.x-backport-finished-singal-GPU-particles
branch
from
d9f1f31 to
48e516b
Compare
|
Added coauthorship |
|
My bad there needs to be an empty line before the co-author message on the commit message: |
Co-authored-by: HolonProduction <[email protected]>
matorin57
force-pushed
the
3.x-backport-finished-singal-GPU-particles
branch
from
48e516b to
2a319ab
Compare
|
Added |
Mickeon
reviewed
Jan 26, 2024
| @@ -21,6 +21,7 @@ | |||
| <return type="Rect2" /> | |||
| <description> | |||
| Returns a rectangle containing the positions of all existing particles. | |||
| [b]Note:[/b] When using threaded rendering this method synchronizes the rendering thread. Calling it often may have a negative impact on performance. | |||
There was a problem hiding this comment.
Not sure if this applies to 3.x as well but it does make sense in theory.
Mickeon
approved these changes
Jan 26, 2024
lawnjelly
approved these changes
Feb 6, 2024
AThousandShips
approved these changes
Feb 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #76859 to 3.x
I moved the changes over by hand instead of cherry picking in git becuase there was significant enough changes in file names and code names that it was easier to do by hand. There was some structural differences; namely using
VSinstead ofRSin 3.x and_notificationbeing if statements instead of a switch in 3.x. I am fairly confident the changes in_notificationshould be semantically the same as the original change but I am not familiar with the difference betweenRSandVS.Related to issue #64094