Expose GeometryInstance3D.custom_aabb property #70114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
custom-aabb
branch
from
14e1a6a to
5d51478
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #70087
As discussed in #57740
set_custom_aabb()was added here #25520 at that time reduz suggested exposing the property and Akien noted that we could add it in a follow up PRSetting a
custom_aabballows the renderer to avoid the expensivemesh_get_aabb()function which recalculates the aabb from skeleton bones. To fully address usability needs we should add some editor functionality to create an appropriately sized AABB. But that is future work, I will need to create a proposal