auto-create repository on push #2478

j-keck · 2017-09-10T05:39:38Z

if the repository doesn't exists at push time,
and the setting 'Repository.Upload.AutoCreate' is 'true'
(default is 'false') create the repository with the given name.

Signed-off-by: Jürgen Keck [email protected]

lunny · 2017-09-10T07:27:44Z

Maybe add some integration tests?

j-keck · 2017-09-10T09:04:42Z

@lunny how can i run the integration test local?

if i run it per integration.test i get this exception:

...
2017/09/10 11:00:27 [...ules/context/repo.go:392 func1()] [E] RepoRef Invalid repo /tmp/gitea/user2/repo16.git: no such file or directory
[Macaron] 2017-09-10 11:00:27: Completed /api/v1/repos/user2/repo16/branches/not-signed 500 Internal Server Error in 2.383334ms
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0xe7ec32]

goroutine 3176 [running]:
testing.tRunner.func1(0xc4218aa780)
...

can i setup the test env local?

my code so far in integrations/repo_test.go - but i'm not sure if this is the right way.

func TestAutoCreateRepo(t *testing.T) {
	prepareTestEnv(t)

	session := loginUser(t, "user2")

	setting.Repository.Upload.AutoCreate = false
	req := NewRequest(t, "GET", "/user2/autocreated.git/info/refs?service=git-receive-pack")
	session.MakeRequest(t, req, http.StatusNotFound)

	setting.Repository.Upload.AutoCreate = true
	req = NewRequest(t, "GET", "/user2/autocreated.git/info/refs?service=git-receive-pack")
	resp := session.MakeRequest(t, req, http.StatusOK)

	// cleanup
	var repo api.Repository
	DecodeJSON(t, resp, &repo)
	req = NewRequestWithValues(t, "POST", "/git/admin/repos/delete", map[string]string{
		"_csrf": GetCSRF(t, session, "/git/admin/repos/delete"),
		"id":    string(repo.ID),
	})
	session.MakeRequest(t, req, http.StatusOK)
}

Thanks.

Morlinest · 2017-09-10T10:16:34Z

@j-keck First you need pgsql or mysql installed (or use docker) and run make test-mysql or make test-pgsql. If you run with latest changes (#2473), you might need to add mysql or pgsql to hosts file with their real IP.

if the repository doesn't exists at push time, and the setting 'Repository.Upload.AutoCreate' is 'true' (default is 'false') create the repository with the given name. Signed-off-by: Jürgen Keck <[email protected]>

j-keck · 2017-09-10T12:27:05Z

I have included a test case.

Rebased on 'master' and squash the impl + test in one commit.

Morlinest · 2017-09-10T13:15:37Z

integrations/repo_test.go

+
+	//
+	// if 'AUTO_CREATE = false', the repo should not be created if it doesn't exist
+	//


Maybe don't use empty comment line.

Morlinest · 2017-09-10T14:23:13Z

routers/repo/http.go

@@ -95,6 +95,13 @@ func HTTP(ctx *context.Context) {
 	}

 	repo, err := models.GetRepositoryByName(repoUser.ID, reponame)
+	if models.IsErrRepoNotExist(err) && setting.Repository.Upload.AutoCreate {


This doesn't look good to me. You should check err for each function. Later err check block is expecting only GetRepositoryByName error, not CreateRepository error. I think something like this:

repo, err := models.GetRepositoryByName(repoUser.ID, reponame) if err != nil { if models.IsErrRepoNotExist(err) { if accessMode == models.AccessModeWrite && setting.Repository.Upload.AutoCreate { repo, err = models.CreateRepository(repoUser, repoUser, models.CreateRepoOptions{ Name: reponame, }) if err != nil { ctx.Handle(http.StatusInternalServerError, "CreateRepository", err) return } } else { ctx.Handle(http.StatusNotFound, "GetRepositoryByName", nil) return } } else { ctx.Handle(http.StatusInternalServerError, "GetRepositoryByName", err) return } }

Edit: Updated if condition in example.

Also you are creating repository on any action, you should check if user is doing push or pull. I think you can use accessMode variable defined few lines above (changing if condition to accessMode == models.AccessModeWrite && setting.Repository.Upload.AutoCreate

Edit: Or use isPull variable.

Morlinest · 2017-09-10T14:26:57Z

routers/repo/http.go

+
+		// if 'CreateRepository' fails, the error are handled in the next 'if err != nil' block
+		repo, err = models.CreateRepository(repoUser, repoUser, models.CreateRepoOptions{
+			Name: reponame,


What about private/public repo? I think repository should be private by default.

should it hard-coded private or with an extra bool setting - like 'AutoCreateAsPrivate'?

I don't think it should be Auto Create specific but probably more generic like 'NewRepositoryDefaultPrivate` and this setting should be reused to set private check box to this default when creating new repository also in UI

good point - i make a extra pr for this tomorrow

@lafriks Actually I think it is more secure to set it private by default. In UI you can tell what you want, but if you autocreate repository, you don't have any option. Also if you use some general variable, you know about it as admin, but not as user.

@Morlinest yes but that does not mean that can't be configurable (as I need myself to to have such option so that I don't have remember to check that check box when creating new repository :) )

Yes, we can add configurable variable, but we should not mix UI and some kind of auto create function.

Morlinest · 2017-09-10T20:10:08Z

modules/setting/setting.go

 		}{
 			Enabled:      true,
 			TempPath:     "data/tmp/uploads",
 			AllowedTypes: []string{},
 			FileMaxSize:  3,
 			MaxFiles:     5,
+			AutoCreate:   false,


bool is false by default, don't need to be set.

Morlinest · 2017-09-10T21:04:08Z

integrations/repo_test.go

+	// if 'AUTO_CREATE = true', the repos should be created
+	//
+	setting.Repository.Upload.AutoCreate = true
+	req = NewRequest(t, "GET", "/user2/autocreated.git/info/refs?service=git-receive-pack")


What if logged user is not same user as in url? You should check both options.

Morlinest · 2017-09-10T21:05:54Z

integrations/repo_test.go

+	//
+	setting.Repository.Upload.AutoCreate = true
+	req = NewRequest(t, "GET", "/user2/autocreated.git/info/refs?service=git-receive-pack")
+	// we don't get a successful response code here, because we don't execute a real 'git push ...'


Can you do real push? (I don't know how git requests look)

Morlinest · 2017-09-10T21:12:57Z

routers/repo/http.go

+	if models.IsErrRepoNotExist(err) && setting.Repository.Upload.AutoCreate {
+
+		// if 'CreateRepository' fails, the error are handled in the next 'if err != nil' block
+		repo, err = models.CreateRepository(repoUser, repoUser, models.CreateRepoOptions{


What about access rights? Logged user don't need to be same as repoUser. You need user is logged and if he can create repository under repoUser (e.g. is admin or wants to add repository to his organization or organization he is in owner team).

j-keck · 2017-09-11T18:21:09Z

my changes was only a quick hack for my local setup - not ready for a pull-request.
give me time till the weekend, then i clean it up.

stale · 2019-01-05T15:07:31Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

stale · 2019-01-19T15:48:40Z

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 10, 2017

lunny added this to the 1.3.0 milestone Sep 10, 2017

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2017

auto-create repository on push

7d5fe39

if the repository doesn't exists at push time, and the setting 'Repository.Upload.AutoCreate' is 'true' (default is 'false') create the repository with the given name. Signed-off-by: Jürgen Keck <[email protected]>

j-keck force-pushed the repository-auto-create branch from 19f0768 to 7d5fe39 Compare September 10, 2017 12:23

Morlinest suggested changes Sep 10, 2017

View reviewed changes

Morlinest reviewed Sep 10, 2017

View reviewed changes

Morlinest suggested changes Sep 10, 2017

View reviewed changes

lunny modified the milestones: 1.3.0, 1.x.x Oct 10, 2017

stale bot added the issue/stale label Jan 5, 2019

stale bot closed this Jan 19, 2019

lafriks removed this from the 1.x.x milestone Jan 21, 2019

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

auto-create repository on push #2478

auto-create repository on push #2478

j-keck commented Sep 10, 2017

lunny commented Sep 10, 2017

j-keck commented Sep 10, 2017

Morlinest commented Sep 10, 2017

j-keck commented Sep 10, 2017

Morlinest Sep 10, 2017

Morlinest Sep 10, 2017 •

edited

Loading

Morlinest Sep 10, 2017 •

edited

Loading

Morlinest Sep 10, 2017

j-keck Sep 10, 2017

lafriks Sep 10, 2017

j-keck Sep 10, 2017

Morlinest Sep 10, 2017 •

edited

Loading

lafriks Sep 10, 2017

Morlinest Sep 10, 2017

Morlinest Sep 10, 2017

Morlinest Sep 10, 2017

Morlinest Sep 10, 2017

Morlinest Sep 10, 2017

j-keck commented Sep 11, 2017

stale bot commented Jan 5, 2019

stale bot commented Jan 19, 2019

auto-create repository on push #2478

auto-create repository on push #2478

Conversation

j-keck commented Sep 10, 2017

lunny commented Sep 10, 2017

j-keck commented Sep 10, 2017

Morlinest commented Sep 10, 2017

j-keck commented Sep 10, 2017

Choose a reason for hiding this comment

Morlinest Sep 10, 2017 • edited Loading

Choose a reason for hiding this comment

Morlinest Sep 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Morlinest Sep 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

j-keck commented Sep 11, 2017

stale bot commented Jan 5, 2019

stale bot commented Jan 19, 2019

Morlinest Sep 10, 2017 •

edited

Loading

Morlinest Sep 10, 2017 •

edited

Loading

Morlinest Sep 10, 2017 •

edited

Loading