feat: allow disabling global distributed locker per job #811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
These changes allow us to disable the globally set distributed locker for a specific job, allowing those scheduled jobs to potentially run multiple times at once by different schedulers.
Which issue(s) does this PR fix/relate to?
Resolves #808
List any changes that modify/break current functionality
A new job option has been introduced to remove any potential breaking changes. Suppose we use the existing
WithDistributedJobLocker
method and treat itsnil
argument as an act of disabling the global locker for the job. In that case, the method won't return an error anymore; therefore,ErrWithDistributedJobLockerNil
will be unused.Have you included tests for your changes?
Yes, a new test case has been added to the distributed locker table test to check whether disabling the job locker while global locker is set works as expected.
Did you document any new/modified functionality?
example_test.go
(didn't need to)README.md
(didn't need to)Notes