Run jobs by Tag #149
Merged
Run jobs by Tag #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RunByTag - Run all jobs that have a specific tag * RunByTagWithDelay - Run all jobs that have a specific tag with a delay in between executions Fix: RemoveByTag function should remove all jobs with the given tag. Not just the first job encountered
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add 2 new functions to Scheduler
RunByTag- Run all jobs that have a specific tagRunByTagWithDelay- Run all jobs that have a specific tag with adelay in between executions
Fix:
RemoveByTagfunction should remove all jobs with the given tag. Notjust the first job encountered
Which issue(s) does this PR fix/relate to?
Resolves #143
List any changes that modify/break current functionality
As mentioned above, currently,
RunByTagonly deletes the first job it finds with a given tag. But this PR modifies that behavior to delete all the jobs with the given tag.Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.md