Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-1145 feat: distribution calculation in emission #249

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jul 3, 2024

feat

  1. distribution logic
  • transfer uGNS to each target with distribution percent
  • each target distribution percent can be change by admin or governance.

@jungju
Copy link

jungju commented Jul 3, 2024

In Golang, comments for functions and types should start with their respective names. The order of code declarations in Golang is import, const, type, var, and func. Does this also apply to Gno?

@notJoon
Copy link
Member

notJoon commented Jul 3, 2024

In Golang, comments for functions and types should start with their respective names. The order of code declarations in Golang is import, const, type, var, and func. Does this also apply to Gno?

Yes, actually gno also encourages to follow the godoc style conventions.

emission/distribution.gno Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Show resolved Hide resolved
emission/distribution.gno Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
emission/distribution.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s force-pushed the GSW-1145-feat-distribution-calculation-in-emission branch from e9c30b9 to 0de2ab4 Compare July 3, 2024 11:49
@r3v4s r3v4s self-assigned this Jul 3, 2024
@r3v4s
Copy link
Member Author

r3v4s commented Jul 3, 2024

In Golang, comments for functions and types should start with their respective names. The order of code declarations in Golang is import, const, type, var, and func. Does this also apply to Gno?

Yes, actually gno also encourages to follow the godoc style conventions.

Following below sequence

interface - type - const - var - new func - public receiver func - private receiver func - public func - private func

dongwon8247
dongwon8247 previously approved these changes Jul 3, 2024
emission/__TEST_0_INIT_VARIABLE_AND_HELPER_test.gno Outdated Show resolved Hide resolved
emission/distribution.gno Show resolved Hide resolved
@jungju jungju requested a review from dongwon8247 July 4, 2024 12:09
@r3v4s r3v4s merged commit 86430b7 into main Jul 4, 2024
@r3v4s r3v4s deleted the GSW-1145-feat-distribution-calculation-in-emission branch July 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants