fix: Remove go.mod replace for gno. Use new gnoclient API. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
fix/remove-replace-for-gnolang-gno
branch
from
8898a29 to
3825cb0
Compare
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gno PR gnolang/gno#2641 has been merged, so we don't need the go.mod replace which was introduced in PR #161 .
vm.MsgCall, etc. instead ofgnoclient.MsgCall, and usesNewCallTx, etc. instead ofMakeCallTx. Therefore, this PR updates api.go to use the new API.convertCallRequest, etc. to maybe return an error if there is no active account, or if thesendamount like "1000ugnot" can't be parsed.