Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add berty validator node in config #2578

Closed
wants to merge 3 commits into from
Closed

chore: add berty validator node in config #2578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c1ba8b
chore: add berty validator node in config
D4ryl00 Jul 12, 2024
6e5cd3c
chore: update the Berty server IP
D4ryl00 Sep 11, 2024
5e675e0
Merge remote-tracking branch 'upstream/master' into chore/add-berty-v…
D4ryl00 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misc/deployments/test4.gno.land/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Some configuration params are required, while others are advised to be set.
- `p2p.laddr` - the listen address for P2P traffic, **specific to every node deployment**. It is advised to use a
reverse-proxy, and keep this value at `tcp://0.0.0.0:<port>`.
- `p2p.max_num_outbound_peers` - the max number of outbound peer connections. **Advised to be `40`**.
- `p2p.persistent_peers` - the persistent peers. ⚠️ **Required to be `g18vg9lgndagym626q8jsgv2peyjatscykde3xju@devx-sen-1.test4.gnodevx.network:26656,g1fnwswr6p5nqfvusglv7g2vy0tzwt5npwe7stvv@devx-sen-2.test4.gnodevx.network:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656`** ⚠️.
- `p2p.persistent_peers` - the persistent peers. ⚠️ **Required to be `g18vg9lgndagym626q8jsgv2peyjatscykde3xju@devx-sen-1.test4.gnodevx.network:26656,g1fnwswr6p5nqfvusglv7g2vy0tzwt5npwe7stvv@devx-sen-2.test4.gnodevx.network:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656`** ⚠️.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would recommend to use ip address over dns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I thought it was good because devx also uses DNS :)
In this case, we will wait a bit to set up the node in our final server (waiting after the provider...).
Thanks!

Copy link
Contributor

@mazzy89 mazzy89 Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use indeed DNS but the DNS resolves always to a static IPs assigned when the network has been created.

If you look at the P2P module, before adding the peer to the list, the net go module resolves the DNS address to IP. As long as your IP is static, you can have your beauty sleep.

Go ahead with DNS if behind that you use a static IP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me share also the rationale why it is better to have anyway static IP. The P2P tendermint module resolves DNS only at the bootstrap time of the node. if a remote peer for any reason change the IP, then the node will lose connection to it because internally it caches in the p2p persistent peers list the old IP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D4ryl00 any updates on this?

- `p2p.pex` - if using a sentry node architecture, should be `false`. **If not, please set to `true`**.
- `p2p.external_address` - the advertised peer dial address. If empty, will use the same port as the `p2p.laddr`. This
value should be **changed to `{{ your_ip_address }}:26656`**
Expand Down
2 changes: 1 addition & 1 deletion misc/deployments/test4.gno.land/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ proxy_app = "tcp://127.0.0.1:26658"
max_packet_msg_payload_size = 1024

# Comma separated list of nodes to keep persistent connections to
persistent_peers = "g18vg9lgndagym626q8jsgv2peyjatscykde3xju@devx-sen-1.test4.gnodevx.network:26656,g1fnwswr6p5nqfvusglv7g2vy0tzwt5npwe7stvv@devx-sen-2.test4.gnodevx.network:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656"
persistent_peers = "g18vg9lgndagym626q8jsgv2peyjatscykde3xju@devx-sen-1.test4.gnodevx.network:26656,g1fnwswr6p5nqfvusglv7g2vy0tzwt5npwe7stvv@devx-sen-2.test4.gnodevx.network:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656,[email protected]:26656"

# Set true to enable the peer-exchange reactor
pex = false # Should be `false` if using a sentry node. Otherwise `true`!
Expand Down
Loading