Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Implement p/demo/bitmap #2115

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented May 15, 2024

Description

From issue : #2119

A simple implementation of bitmap in p/demo/bitmap :

  • Logic code
  • Test cases
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from a team as code owners May 15, 2024 09:56
@linhpn99 linhpn99 requested review from gfanton and zivkovicmilos and removed request for a team May 15, 2024 09:56
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label May 15, 2024
@linhpn99 linhpn99 changed the title Implement Bitmap package feat(examples): Implement Bitmap package May 15, 2024
@linhpn99
Copy link
Contributor Author

linhpn99 commented May 15, 2024

@zivkovicmilos @leohhhn what do you think about this utility ?

@linhpn99 linhpn99 changed the title feat(examples): Implement Bitmap package feat(examples): Implement p/bitmap May 15, 2024
@linhpn99 linhpn99 changed the title feat(examples): Implement p/bitmap feat(examples): Implement p/demo/bitmap May 15, 2024
@linhpn99 linhpn99 requested a review from moul May 23, 2024 03:18
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (65ee7a5) to head (94834d1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2115      +/-   ##
==========================================
- Coverage   60.24%   60.21%   -0.03%     
==========================================
  Files         562      562              
  Lines       75031    75031              
==========================================
- Hits        45200    45183      -17     
- Misses      26458    26473      +15     
- Partials     3373     3375       +2     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.05% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Dec 6, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 6, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request
🔴 The pull request head branch must be up-to-date with its base

Manual Checks

  • The pull request description provides enough details
Debug
Automated Checks
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (linhpn99:add-package-bitmap) is up to date with base (master): behind by 212 / ahead by 49

Manual Checks
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@github-actions github-actions bot removed the Stale label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants