-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "Improve BFT Tests Stability (#1385)" #1441
Conversation
This reverts commit 63ff15b. Signed-off-by: gfanton <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1441 +/- ##
==========================================
- Coverage 56.32% 56.06% -0.26%
==========================================
Files 422 421 -1
Lines 65699 65457 -242
==========================================
- Hits 37003 36700 -303
- Misses 25815 25891 +76
+ Partials 2881 2866 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am blocking the merge because it will reintroduce the annoying CI. We need time to make the final fix.
However, let's keep this PR open to make sure to address the underlying problem instead of ignoring it.
I'll mark this pull request as blocking the launch, as it was already the case for #1320.
After further discussion with Jae, it is evident that fixing this issue promptly is more important than delaying it. The usual concern is that if we try to ignore such problem, it may be forgotten later. However, what makes this issue unique is that it used to occur less frequently in the past. Although I don't have precise numbers, the occurrence rate was likely around 1 in 10, but now it has increased to 5 in 10. Therefore, the situation has worsened over time. By hiding the issue, we not only postpone the fix, but also allow the problem to grow silently. I will merge this pull request now, which will inevitably cause the CI to become unstable again. However, by doing so, we can ensure that it is prioritized and fixed. Additionally, we should consider checking the other unstable tests now rather than later, specifically #202. |
This PR reverts gnolang#1385 following @jaekwon gnolang#1320 (comment) <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Signed-off-by: gfanton <[email protected]>
This PR reverts #1385 following @jaekwon #1320 (comment)
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description