-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few bugs #520
a few bugs #520
Conversation
Sometimes the synchronous calculation of the rectangular area fails
Thank you for this pull request. I cannot reproduce the problem here, so maybe it is related to your application. Can you post a video that I can understand the intention of this pull request? |
You should add many tab widgets. |
Should I test this under Windows or Linux or is it reproducible on both systems? |
windows |
memory leak
saveState() may use the floatingDockContainer to be deleted
Please describe the exact steps I need to do to reproduce the problem that you try to solve with this change: QTimer::singleShot(0, [&, TabWidget]{
_this->ensureWidgetVisible(TabWidget);
}); If I cannot reproduce the problem here, I will not merge this change - sorry. |
|
remove dock container
Thank you for your bug fixes. I was able to reproduce the problem here and merged your changes. |
This fix seems to have introduced a regression when _this is deleted before the lambda slot occurred, for example deleting the DockManager (and consequently _this) immediately after the execution of updateTabs function (we encountered this problem in our software). A safer solution can be the following:
|
Sometimes the synchronous calculation of the rectangular area fails