Fix crash caused by dockContainerWidget not removing auto hide dock #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
container widget properly.
|
Thank you for your pull request. I added your change to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @githubuser0xFFFF, thanks for releasing the Auto hide feature :). This is a small fix for a crash that I found. Here's how to reproduce it:
If you have two windows and the sub window has an auto hide widget:
If you press right click and then "detach" the auto hide container:
Then you delete the previous window:
You'll get a crash. I believe this is being caused by the destructor of the AutoHideDockContainer not removing the correct registered auto hide widget from the correct container:
You can see that dockContainer() is getting the dockArea->dockContainer(), which has already been detached. It should try to remove only it's parent dockContainer():