Auto hide feature #452

SyarifFakhri · 2022-09-07T02:07:06Z

Added main functionality for auto hiding docks
Auto hide toggle button is added in the dock area titlebar
Side tab bars are added to the left and right of each window
Add config for enabling the auto hide button, left side bar area and the right side bar area
Add logic for save state and restore state with the auto hide functionality

Fix bug where pin and unpin doesn't work

githubuser0xFFFF

I fixed all build issues that occured when building your pull request on my Windows machine with qmake and pushed everything to a new branch auto_hide_feature

examples/autohide/CMakeLists.txt

examples/centralwidget/autohide.pro

examples/autohide/CMakeLists.txt

src/DockContainerWidget.cpp

src/OverlayDockContainer.cpp

src/SideTabBar.h

src/SideTabBar.cpp

src/DockWidgetSideTab.h

src/DockWidgetSideTab.cpp

githubuser0xFFFF · 2022-09-07T09:03:19Z

Thank you for this big merge request with a great new feature. I fixed all build issues in your pull request that occured when building everything on Windows with MinGW and qmake.

When I run the demo application on WIndows to test the feature, I can see an issue that I will document in the next days.

githubuser0xFFFF · 2022-09-07T09:11:03Z

The current implementation has a bug, that causes a wrong painting on Windows. To reproduce this, execute the following steps:

Start the demo application AdvancedDockingSystemDemo.exe
click the pin in the group highlighted in the following picture
now click the Active X 0 or Label 4 side tab - the sidebar widget is not paintet properly (no title bar)
if you click the Label 1 side tab, then the sidebar is paintet properly:

Because you implemented the feature, it is easier for you to find the problem.

SyarifFakhri · 2022-09-07T10:14:43Z

Thanks for reviewing it so quickly! I will merge this with the auto hide branch you created and look into the issues you brought up. Please let me know if you find anything else :). I'm still testing this, so I will post more bug fixes as I go along, will let you know once it's fully ready for review!

…ault auto hide feature.

edge border when not selected

widgets when toggling overlay Also centralized and simplified the logic for the title bar button visibility

…e click shortly after a mouse over collapse event

…Bars to dock container

… backward compatible

…vanced-Docking-System into auto_hide_feature

…emoveDockWidget(DockWidget) call when restoring state

…vanced-Docking-System into auto_hide_feature

githubuser0xFFFF · 2022-11-10T05:23:42Z

@SyarifFakhri Thank you for your contribution. I'm closing the pull request now because development now takes place in the autohide_feature branch.

FelixBer · 2022-11-14T18:36:51Z

Just a heads up, QMouseEvent::globalPos is deprecated in Qt6:

https://doc.qt.io/qt-6/qmouseevent-obsolete.html#globalPos

Used twice around

Qt-Advanced-Docking-System/src/AutoHideDockContainer.cpp

Line 511 in 7dee00f

auto pos = mapFromGlobal(me->globalPos());

Also,
#include "DockWidgetTab.h"
#include "DockingStateReader.h"
appear to be unused in AutoHideDockContainer.cpp

githubuser0xFFFF · 2022-11-14T21:18:25Z

@FelixBer Thank you. Fixed it.

SyarifFakhri · 2022-11-21T01:57:54Z

@githubuser0xFFFF
Just something I noticed while building this:
1.

Qt-Advanced-Docking-System/src/AutoHideTab.h

Line 43 in 8bc2236

struct DockContainerWidgetPrivate;

This gives a warning that struct was previously declared as a class

Qt-Advanced-Docking-System/demo/CMakeLists.txt

Line 15 in 8bc2236

StatusDialog.ui

I believe the ImageViewer.cpp and RenderWidget.cpp are missing in this CMakeLists.txt :)

githubuser0xFFFF · 2022-11-21T07:02:50Z

@SyarifFakhri Thank you. Fixed it. Please test.

I have a question. In qmake I can add an RC file on Windows with the RC_FILE statement (see demo.pro RC_FILE += app.rc). Do you know how to add this for a CMake file?

SyarifFakhri · 2022-11-21T07:42:16Z

Cheers! It does build now :)

In qmake I can add an RC file on Windows with the RC_FILE statement (see demo.pro RC_FILE += app.rc). Do you know how to add this for a CMake file?

I believe you just need to add it like so:

Let me know if that works for you :)

SyarifFakhri · 2022-11-22T01:47:37Z

@githubuser0xFFFF I did find one more issue while testing this. If you open an auto hide dock tab and open the context menu as shown:

Then click anywhere inside the dock but outside the context menu, the dock will collapse.

I believe that's due to this code here:

Qt-Advanced-Docking-System/src/AutoHideDockContainer.cpp

Line 507 in 5a18526

if (widget && widget->window() != this->window())

The context menu is considered as a different window, so it closes. I think one fix would be to check if the widget is a descendant of the auto hide widget, and don't collapse it if it is perhaps?

githubuser0xFFFF · 2022-11-22T10:16:28Z

@SyarifFakhri Thank you - good catch. I changed the implementation now. Now the auto hide container is not closed, if the user clicks into another floating window. It will only get closed in the following cases:

user clicks in the same dock container but outside of the auto hide widget
user clicks the auto hide tab
user starts dragging a floating widget that is not the container of this auto hide widget
user starts dragging a docked widget

Please test, if this is ok for you.

githubuser0xFFFF · 2022-11-22T11:48:52Z

@SyarifFakhri I noticed that there are still some things, that needs to get fixed with hiding the auto hide widget

githubuser0xFFFF · 2022-11-22T20:48:53Z

@SyarifFakhri Ok, I think I finally fixed the eventFilter function ion auto hide widget to work properly. Please test.

SyarifFakhri · 2022-11-23T02:46:34Z

Everything seems good. Thanks for the fixes!

yuriyoung · 2023-11-20T12:17:17Z

how to pin/unpin(auto hide) a group?

githubuser0xFFFF · 2023-11-20T15:20:21Z

@yuriyoung Just read the manual and play around with the demo application and you will find it out in some minutes.

Syarif Fakhri added 5 commits September 7, 2022 10:12

Merge branch 'master' into auto_hide_feature

e456503

add pin icon

1a903e7

swap position of auto hide button and detach group button

4a77580

Fix toggle view through the actions menu not working correctly

9735f41

Make tabs menu hidden when overlayed

1d9902b

githubuser0xFFFF self-assigned this Sep 7, 2022

githubuser0xFFFF added enhancement under review labels Sep 7, 2022

Fix bug where dragging an overlayed widget would cause it to be empty

302fcd1

Fix bug where pin and unpin doesn't work

githubuser0xFFFF self-requested a review September 7, 2022 08:24

Fixed build issues of original pull request

068797d

githubuser0xFFFF requested changes Sep 7, 2022

View reviewed changes

githubuser0xFFFF mentioned this pull request Sep 7, 2022

Can you add Auto Hide functionality? #147

Closed

Syarif Fakhri added 14 commits September 8, 2022 11:18

Re added back in CentralWidgetExample after mistakenly removing it

de4a59d

Remove auto hide feature being set by default. Add config for the def…

8bfb98e

…ault auto hide feature.

Add left right styling to the dock widget side tab

0087a1b

Add overlay splitter object name

ecccba4

fix the border styling of the dock widget side tab when not focused

5ddb02c

Fix side tab bar area name being saved wrong in the XML

a279e71

Change the styling - Now the dock widget side tab has a gray left/right

be4e5a8

edge border when not selected

Fix the side tab widget not updating style when its restored from XML

37edf47

Remove None and Bottom from the SideTabBarArea enum

9bfd77a

Add title label to the overlayed dock area

af549d8

Fix bug where undock button would be show incorrectly in floating dock

c1df05b

widgets when toggling overlay Also centralized and simplified the logic for the title bar button visibility

Whitespace changes only

fac8126

update default stylesheet

3ec395f

Add hover styling

60c2200

githubuser0xFFFF and others added 16 commits November 7, 2022 08:19

Implemented custom close handling for dynamically created image viewers

be86a77

Dynamically created image viewer now loads random image in demo

2569e0a

Prevent accidental hiding collapsing of an auto hide widget by a mous…

95b627e

…e click shortly after a mouse over collapse event

Fixed wrong image filename in demo application

6cdea82

Added documentation for Auto-Hide feature

0073870

Fixed emission of top level event in DockContainerWidget

5a9f23a

Merge branch 'originf_auto_hide_feature' into auto_hide_feature

33e6098

Fixed bug in dropIntoSection() caused by the addition of AutoHideSide…

64bd902

…Bars to dock container

Reverted file version change for saved state data because the file is…

89cca4c

… backward compatible

User rootSplitter() function instead of searching for child widget

208c804

Added app icon for demo app

f132255

Updated ads_logo.svg to fix size for mobile page

c646d13

Merge branch 'master' into auto_hide_feature

38dfd51

Merge branch 'auto_hide_feature' of github.com:githubuser0xFFFF/Qt-Ad…

00c05eb

…vanced-Docking-System into auto_hide_feature

Fixed CAutoHideDockContainer::addDockWidget to prevent OldDockArea->r…

8e7b7f5

…emoveDockWidget(DockWidget) call when restoring state

Merge branch 'auto_hide_feature' of github.com:githubuser0xFFFF/Qt-Ad…

17bea8c

…vanced-Docking-System into auto_hide_feature

githubuser0xFFFF closed this Nov 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto hide feature #452

Auto hide feature #452

SyarifFakhri commented Sep 7, 2022

githubuser0xFFFF left a comment

githubuser0xFFFF commented Sep 7, 2022 •

edited

Loading

githubuser0xFFFF commented Sep 7, 2022

SyarifFakhri commented Sep 7, 2022

githubuser0xFFFF commented Nov 10, 2022

FelixBer commented Nov 14, 2022

githubuser0xFFFF commented Nov 14, 2022

SyarifFakhri commented Nov 21, 2022 •

edited

Loading

githubuser0xFFFF commented Nov 21, 2022

SyarifFakhri commented Nov 21, 2022

SyarifFakhri commented Nov 22, 2022

githubuser0xFFFF commented Nov 22, 2022 •

edited

Loading

githubuser0xFFFF commented Nov 22, 2022

githubuser0xFFFF commented Nov 22, 2022

SyarifFakhri commented Nov 23, 2022

yuriyoung commented Nov 20, 2023

githubuser0xFFFF commented Nov 20, 2023

Auto hide feature #452

Auto hide feature #452

Conversation

SyarifFakhri commented Sep 7, 2022

githubuser0xFFFF left a comment

Choose a reason for hiding this comment

githubuser0xFFFF commented Sep 7, 2022 • edited Loading

githubuser0xFFFF commented Sep 7, 2022

SyarifFakhri commented Sep 7, 2022

githubuser0xFFFF commented Nov 10, 2022

FelixBer commented Nov 14, 2022

githubuser0xFFFF commented Nov 14, 2022

SyarifFakhri commented Nov 21, 2022 • edited Loading

githubuser0xFFFF commented Nov 21, 2022

SyarifFakhri commented Nov 21, 2022

SyarifFakhri commented Nov 22, 2022

githubuser0xFFFF commented Nov 22, 2022 • edited Loading

githubuser0xFFFF commented Nov 22, 2022

githubuser0xFFFF commented Nov 22, 2022

SyarifFakhri commented Nov 23, 2022

yuriyoung commented Nov 20, 2023

githubuser0xFFFF commented Nov 20, 2023

githubuser0xFFFF commented Sep 7, 2022 •

edited

Loading

SyarifFakhri commented Nov 21, 2022 •

edited

Loading

githubuser0xFFFF commented Nov 22, 2022 •

edited

Loading