Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the full stack in error log messages #726

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jan 20, 2021

Ensure we only show the truncated error message in the popup. This will help with debugging.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • [n/a] Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-dsp has been cc'd in all issues for UI or other user-facing changes made by this pull request.

Ensure we only show the truncated error message in the popup.

This will help with debugging.
Also, remove an errant `only`, which was preventing some tests from
running.
@aeisenberg aeisenberg merged commit 044bc30 into github:main Jan 20, 2021
@aeisenberg aeisenberg deleted the aeisenberg/full-stack branch January 20, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants