Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most recent commit information and sorting #2637

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Remove most recent commit information and sorting #2637

merged 2 commits into from
Jul 25, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Jul 25, 2023

Removes the most recent commit information and sorting option from the variant analysis results view. This information has been confusing to users and not generally used, so we've decided to remove support for it.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners July 25, 2023 12:57
robertbrignull
robertbrignull approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and worked for me when I tested it

shati-patel
shati-patel approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🌻

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@charisk charisk enabled auto-merge (squash) July 25, 2023 13:56
@charisk charisk merged commit b87fe94 into main Jul 25, 2023
@charisk charisk deleted the charisk/remove-last-updated branch July 25, 2023 14:15
@charisk charisk mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charisk @robertbrignull @shati-patel