Update rubocop v0.52.0 - Remove SpaceInsideBrackets #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with SpaceInsideArrayLiteralBrackets & SpaceInsideReferenceBrackets per PR in v0.52.0 https://github.com/bbatsov/rubocop/pull/5149/files
joshRpowell
changed the title
|
Can you also update this PR so that the enforce style is set to |
|
You know, I just realized #19 was opened to address this. Thanks fo your contribution, I'll try to get that PR moving along. |
|
Just catching up on my messages. Thanks for the update!
…On Tue, Dec 19, 2017 at 10:13 AM, Garen Torikian ***@***.***> wrote:
Closed #20 <#20>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGa7Xg374mERWBk9A5qF84I9yIS0BcUkks5tB9KvgaJpZM4RDxXs>
.
--
*Josh Powell*
[email protected] / 860.977.2006
*Innovative Operations*
www.innovativeops.co
|
|
@gjtorikian still see SpaceInsideBrackets rubocop-github/config/default.yml Line 55 in c8345e1 |
|
Argh, no, I just haven't had enough coffee. Thanks! |
tijmenb
pushed a commit
to alphagov/govuk-lint
that referenced
this pull request
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with SpaceInsideArrayLiteralBrackets & SpaceInsideReferenceBrackets
per PR in v0.52.0