-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section for the Important alert type to the style guide #35875
Conversation
and an example rendering
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Michael21107 Thanks so much for opening this PR! I'll get this triaged for review, and as mentioned earlier, have the team provide suggestions regarding the alert type description 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michael21107 - thanks for fixing this omission ✨
I made two suggestions that I'm going to apply.
content/contributing/style-guide-and-content-model/style-guide.md
Outdated
Show resolved
Hide resolved
content/contributing/style-guide-and-content-model/style-guide.md
Outdated
Show resolved
Hide resolved
content/contributing/style-guide-and-content-model/style-guide.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes:
#35860
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adds the fifth alert type, Important, to the style guide.
Check off the following: