-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: database
source models for github.com/beego/beego/client/orm
#18465
base: main
Are you sure you want to change the base?
Go: database
source models for github.com/beego/beego/client/orm
#18465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Click to show differences in coveragegoGenerated file changes for go
- `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",63,63,213
+ `beego <https://beego.me/>`_,"``github.com/astaxie/beego*``, ``github.com/beego/beego*``",93,63,213
- Totals,,420,943,1532
+ Totals,,450,943,1532
- github.com/astaxie/beego,71,21,21,,,,34,,5,,,,,,30,2,,,,,,,,21,,21,
+ github.com/astaxie/beego,71,31,21,,,,34,,5,,,,,,30,2,,,,,10,,,21,,21,
- github.com/beego/beego,142,42,42,,,,68,,10,,,,,,60,4,,,,,,,,42,,42,
+ github.com/beego/beego,142,62,42,,,,68,,10,,,,,,60,4,,,,,20,,,42,,42, |
- ["group:beego-orm", "DQL", True, "Read", "", "", "Argument[0]", "database", "manual"] | ||
- ["group:beego-orm", "DQL", True, "ReadWithCtx", "", "", "Argument[1]", "database", "manual"] | ||
- ["group:beego-orm", "DQL", True, "ReadForUpdate", "", "", "Argument[0]", "database", "manual"] | ||
- ["group:beego-orm", "DQL", True, "ReadForUpdateWithCtx", "", "", "Argument[1]", "database", "manual"] | ||
- ["group:beego-orm", "DQL", True, "ReadOrCreate", "", "", "Argument[0]", "database", "manual"] | ||
- ["group:beego-orm", "DQL", True, "ReadOrCreateWithCtx", "", "", "Argument[1]", "database", "manual"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this in the last review, but in older versions (2/3 of the package paths), this type was called Ormer
(here and here). These models should be duplicated for that type. I would just use the same package group, as the name isn't used in later versions.
Please also add tests for it. You'll need to make new stubs for one of the other package paths. Go makes it easy to import two versions of the same library in the same file - you just give one of them a different name (as in import "github.com/astaxie/beego/orm" oldorm
) and use that when referring to them (oldorm.NewOrm()
instead of orm.NewOrm()
). So you can keep the tests in the same file. Or you can put them in a separate file, if you prefer.
--- | ||
category: minorAnalysis | ||
--- | ||
* `database` local source models have been added for the `github.com/beego/beego/client/orm` package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are modelling a package with multiple different import paths, it might be better/more accurate to just refer to it by name.
* `database` local source models have been added for the `github.com/beego/beego/client/orm` package. | |
* `database` local source models have been added for the Beego ORM package. |
Adds models for the
github.com/beego/beego/client/orm
package.Pull Request checklist
All query authors
- [ ] All new queries have appropriate.qhelp
. See the documentation in this repository.- [ ] New and changed queries have correct query metadata. See the documentation in this repository.Internal query authors only
- [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).- [ ] Adding a new query? Consider also adding the query to autofix.