Data flow: Prune parameter-self flow in stage 1 #18333
Merged
+55
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/stage1-param-self-prune
branch
2 times, most recently
from
1837862 to
5cef673
Compare
hvitved
force-pushed
the
dataflow/stage1-param-self-prune
branch
from
5cef673 to
06ba814
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll: Language not supported
- shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
aschackmull
reviewed
Jan 7, 2025
Comment on lines
597
to
600
| pragma[nomagic] | ||
| private predicate fwdFlowInParam(DataFlowCall call, ParamNodeEx p, Cc cc) { | ||
| fwdFlowIn(call, _, cc, p) | ||
| } |
There was a problem hiding this comment.
The columns call and p ought to functionally determine arg on almost all cases, so I think it's better to inline this projection rather than materialising additional tuples.
aschackmull
reviewed
Jan 7, 2025
Yes, I was, but performance turned out to be terrible :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example tuple counts (~10 % reduction in stage 1):
Before
After