Gren fails when used on first release

[donmahallem]

Hi.

I ran into an issue when using gren for the very first release.
It will crash due to undefined being inside the selectedTags array.

github-release-notes/lib/src/Gren.js

Line 1132 in 617cb77

loaded(`Tags found: ${selectedTags.map(({ name }) => name).join(', ')}`);

This is due to releaseDates only containing one item in these lines:

github-release-notes/lib/src/Gren.js

Lines 1129 to 1130 in 617cb77

	const releaseDates = this._sortReleasesByDate(await Promise.all(this._getTagDates(tags)));
	const selectedTags = (this._getSelectedTags(releaseDates) || [releaseDates[0], releaseDates[1]]);

and trying to retrieve two which leads to selectedTags to contain an undefined as second element which will cause an

TypeError: Cannot read property 'name' of undefined

in line 1132 as referenced above.

[alexcanessa]

Good catch, thanks

[brettcurtis]

When can we expect this to be released ? I'm hoping to use this in some of our pipelines and having same issue.

[alexcanessa]

@brettcurtis the release that includes this should be rolled out on Monday. I'll keep you posted on this issue.

[alexcanessa]

@brettcurtis release done https://github.com/github-tools/github-release-notes/releases/tag/0.17.2

Please let me know if it's all fixed :)

[brettcurtis]

Hmm, still failing - it's highly possible I'm doing something wrong:

gren release
Getting gren config from local file /home/brett/repos/my-org/terraform-google-billing-budget/.grenrc.js

🤖  - Generate release notes:
===================================
✔ Releases found: 0
⠸ Getting tagsTypeError: Cannot read property 'name' of undefined
    at /usr/local/lib/node_modules/github-release-notes/dist/Gren.js:1936:55
    at Array.map (<anonymous>)
    at Gren._callee18$ (/usr/local/lib/node_modules/github-release-notes/dist/Gren.js:1935:70)
    at tryCatch (/usr/local/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/usr/local/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.(anonymous function) [as next] (/usr/local/lib/node_modules/github-release-notes/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/usr/local/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /usr/local/lib/node_modules/github-release-notes/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

I can get it to run when I add the tag:

gren release --tags=1.0
Getting gren config from local file /home/brett/repos/my-org/terraform-google-billing-budget/.grenrc.js

🤖  - Generate release notes:
===================================
✔ Releases found: 0
✔ Tags found: 1.0
✔ Issues found: 1
✔ v1.0 has been successfully created!
See the results here: https://github.com/my-org/terraform-google-billing-budget/releases/tag/1.0```

[donmahallem]

I just did a quick test with a new clean repo and 0.17.2.

It does appear that the fix isn't included in this release. If I look into the distributed source it doesn't appear to be there.

[alexcanessa]

🤦 my bad.

Please check 0.17.3

[brettcurtis]

Looks good thanks!

[donmahallem]

I guess the issue can be closed now.