-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit author's name link is incorrect #158
Comments
Hey @jfix, thanks for your feedback. This one can be easily tackled by changing what gets passed to the template. github-release-notes/lib/src/Gren.js Lines 429 to 436 in 78786b3
The information should come directly from //see https://developer.github.com/v3/repos/commits/#get-a-single-commit "author": {
"login": "octocat" |
Just ran into the same thing and some other person showed up in my release notes... 💩 Has anyone taken this one on yet? In the meantime I manually fixed my release notes. |
GitHub markdown converts @-references with links to user profiles. Using the full author name means potentially including a space which breaks this linking behavior. Instead of the author name (Ex: Mario Tacke), this fix uses the author login (Ex: mariotacke) to form a proper link in the release notes and changelog). This fixes github-tools#158
GitHub markdown converts @-references with links to user profiles. Using the full author name means potentially including a space which breaks this linking behavior. Instead of the author name (Ex: Mario Tacke), this fix uses the author login (Ex: mariotacke) to form a proper link in the release notes and changelog). This fixes #158
This is actually still a bug as the |
I've just started using
gren
so maybe this is just bad usage on my part.I've configured
gren
with the CLI (very nice 👍), and this is the config file:I've generated the Changelog for an existing release via
gren release --override
. While this works well, I've noticed that each list item ends with the author name which is supposed to be clickable. I don't know why, but in my case, it uses my name, "Jakob Fix", instead of my id, @jfix. Therefore, because of the prefixed @ it makes the first name, @jakob, clickable, which is another Github user.Here's an example from the
CHANGELOG.md
file which I also generated usinggren changelog --override
:I've added the configuration option
username: "jfix"
to the configuration file, hoping this would change things, but to no avail, unfortunately.Here is the release: https://github.com/jfix/pac-toolkit/releases/tag/v1.1.0
The text was updated successfully, but these errors were encountered: