vim: update configuration to include theme files #4893
Conversation
src/config/vim.zig
Outdated
| \\if exists("current_compiler") | ||
| \\ finish | ||
| \\endif | ||
| \\let current_compiler = "ghostty" | ||
| \\ | ||
| \\CompilerSet makeprg=ghostty\ +validate-config | ||
| \\CompilerSet makeprg=ghostty\ +validate-config\ --config-file='%:p' | ||
| \\CompilerSet errorformat=%f:%l:%m |
There was a problem hiding this comment.
I didn't take a closer look at this before, but is this efm actually correct? When I run ghostty +validate-config with an invalid option it does not print out the filename or line number, only the message. In which case 'errorformat' should just be %m. If validate-config ever does print the filename and line number in filename:line:message format, then this would be correct.
There was a problem hiding this comment.
It's mostly correct. Ghostty has ~3 or more output formats depending on where an error happens. You should see one of the three follow forms:
/home/<user>/.config/ghostty/themes/testing:4:not-a-field: unknown field<file>:<number>: <message>"(looking at possibilities indiagnostic.zig.write, may not be possible atm)<message>
Those examples can go wrong in the current code:
not-a-field: unknown field(location = none, anytime a key is replayed)error opening config-file /home/<user>/.config/ghostty/themes/nope: error.FileNotFound(non-reproducible steps generated inloadRecursiveFilesfrom originally fixed keys)
And cli output:
cli:4:palette: invalid value "not right"(not technically a worry here)
There was a problem hiding this comment.
| \\CompilerSet errorformat=%f:%l:%m | |
| \\CompilerSet errorformat=%f:%l:%m | |
| \\CompilerSet errorformat+=%m |
I think will work but I was unsure where to verify that second step in vim. The %m output was ignored by :cw when tested.
There was a problem hiding this comment.
Those examples can go wrong in the current code:
not-a-field: unknown field(location = none, anytime a key is replayed)
Ah that explains it, I was testing it by using an unknown field.
I think will work but I was unsure where to verify that second step in vim.
Rather than two CompilerSets I'd suggest either (1) using a comma to set both in one command: CompilerSet errorformat=%f:%l:%m,%m or (2) leaving it as-is and updating the error handling code in Ghostty to always print the filename and line number (this seems like the best approach to me, personally, but I haven't looked into how difficult that'd be).
There was a problem hiding this comment.
I'll do (1) for this PR. (2) is something I've been poking at. It's just taking a while to unwind the current code.
anund
force-pushed
the
vim_compiler_improvements
branch
2 times, most recently
from
791e889 to
fe47aa4
Compare
anund
force-pushed
the
vim_compiler_improvements
branch
from
fe47aa4 to
c03828e
Compare
Extends vim validation and file type detection to theme files
cc @gpanders @beaumccartney (as you were involved on the previous vim PR)