GTK: refactor headerbar into separate Adwaita & GTK structs #4850
+203
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
approved these changes
Jan 9, 2025
pluiedev
reviewed
Jan 10, 2025
jcollie
force-pushed
the
gtk-headerbar-refactor
branch
from
b92e566 to
010f4d1
Compare
|
Like the refactor, trusting you on behavior. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one behavioral change here. Before this patch, if
gtk-titlebar=falsewe never created a headerbar. This explicitly contradicted the comments in the source, and the documentation forgtk-titlebarimply that if a window starts out without a titlebar it can be brought back later with thetoggle_window_decorationskeybind action.After this patch, a headerbar is always created, but if
gtk-titlebar=falseorwindow-decoration=falseit's immediately hidden.I'm not sure how this interacts with the current SSD/CSD detection that seems to happen when running Ghostty on non-Gnome DEs so it'll be important to get #4724 merged (plus any follow ups) to enable more explicit control of SSD/CSD.