Config: apply xdg system config files #4845
Open
+132
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjrochford
changed the title
mitchellh
requested changes
Jan 9, 2025
| // We must reverse the order of the iterator because the first xdg config | ||
| // dir must takes importance per the spec https://specifications.freedesktop.org/basedir-spec/latest/#variables | ||
| var xdg_config_dirs = std.ArrayList([]const u8).init(alloc); | ||
| defer xdg_config_dirs.deinit(); |
There was a problem hiding this comment.
Instead of all this machinery, the DirIterator could do a reverse iteration using std.mem.lastIndexOf to implement your own iterator. I would recommend this route.
|
Also please note my feedback on @jcollie's PR, it applies here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4506
Applies the config files inside the XDG_CONFIG_DIRS with the first file taking precedence.