Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk: add option for numeric icons on tabs #4464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcollie
Copy link
Collaborator

@jcollie jcollie commented Jan 3, 2025

Screenshot From 2025-01-02 22-59-06

@tristan957
Copy link
Collaborator

I don't love this particular solution, but would be interested in unlocking this feature for people. I think templating in the window (surface) title would make more sense.

@jcollie
Copy link
Collaborator Author

jcollie commented Jan 3, 2025

I don't love this particular solution, but would be interested in unlocking this feature for people. I think templating in the window (surface) title would make more sense.

The big reason that I switched to an icon was that I had better control over the looks of the icon. I initially tried using unicode chars like "①" but they were a little small and didn't look very good in the default Cantarell font. By using an icon we can have much better control over it's appearance, maybe even dynamically generating it since we do have the machinery for that.

@tristan957
Copy link
Collaborator

But why not just use ascii numbers? Imagine a config like:

tab-title-prefix = {tab-index} {emdash}

Something stupid like that.

@jcollie
Copy link
Collaborator Author

jcollie commented Jan 3, 2025

But why not just use ascii numbers? Imagine a config like:

tab-title-prefix = {tab-index} {emdash}

Something stupid like that.

Because I wanted something that would be visually distinct from the tab title. If it's just text in the same font as the tab title that's much harder to do.

Also, there's the possibility of dynamically generating the icons. Some possible uses are spinners/beachballs/progress meters for the ConEmu OSC 9;4 codes. Probably a lot of other creative uses we can come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants