Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: add configuration support for quick-terminal-size #2385

Closed
wants to merge 1 commit into from

Conversation

vibe
Copy link
Collaborator

@vibe vibe commented Oct 5, 2024

Introduces quick-terminal-size config property to allow scaling the quick size window's initial size (based on position).

@mitchellh
Copy link
Contributor

Hi, thanks! This is on the right path but not the design I outlined in #2384. I'm open to suggestions in #2384 but since its still tagged as needs-confirmation its not technically an accepted design so I don't want to accept any PRs for it yet.

@vibe
Copy link
Collaborator Author

vibe commented Oct 5, 2024

Hi, thanks! This is on the right path but not the design I outlined in #2384. I'm open to suggestions in #2384 but since its still tagged as needs-confirmation its not technically an accepted design so I don't want to accept any PRs for it yet.

Thanks for dropping that link, I did this last night and had no idea there was an ongoing conversation.

I'll review the issue and the design!

@mitchellh
Copy link
Contributor

Yeah just started having it this morning, in general I prefer features to be discussed because it avoids situations where I have to say "sorry but not like this" after a bunch of work is done. Luckily you're on the right path...

@mitchellh
Copy link
Contributor

Going to close this until the new implementation is available. Thank you ❤️

@mitchellh mitchellh closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants