Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : fix openblas build #2511

Merged
merged 5 commits into from
Oct 30, 2024
Merged

ci : fix openblas build #2511

merged 5 commits into from
Oct 30, 2024

Conversation

ggerganov
Copy link
Owner

fix #2508

@tamo
Copy link
Contributor

tamo commented Oct 25, 2024

Currently I don't have access to windows but
is this related?

https://stackoverflow.com/a/73763184
(vcpkg install pkgconf)

@ggerganov
Copy link
Owner Author

Possibly, though I'm not sure how to modify the workflow file to apply this.

- choco install pkgconfiglite (vcpkg-pkgconf doesn't contain pkg-config executable?)
- vcpkg install openblas (otherwise it is not detected now)
@ggerganov ggerganov merged commit 19dca2b into master Oct 30, 2024
87 checks passed
@ggerganov ggerganov deleted the gg/ci-fix-openblas branch October 30, 2024 10:58
lyapple2008 pushed a commit to lyapple2008/whisper.cpp.mars that referenced this pull request Nov 2, 2024
* ci : fix openblas build

* cont : would this work?

* ci : I'm sorry, windows

* cont : disabled wrong build

* ci : fix openblas build with pkgconfiglite (ggerganov#2517)

- choco install pkgconfiglite (vcpkg-pkgconf doesn't contain pkg-config executable?)
- vcpkg install openblas (otherwise it is not detected now)

---------

Co-authored-by: Tamotsu Takahashi <[email protected]>
adutilleul pushed a commit to adutilleul/whisper.cpp that referenced this pull request Nov 19, 2024
* ci : fix openblas build

* cont : would this work?

* ci : I'm sorry, windows

* cont : disabled wrong build

* ci : fix openblas build with pkgconfiglite (ggerganov#2517)

- choco install pkgconfiglite (vcpkg-pkgconf doesn't contain pkg-config executable?)
- vcpkg install openblas (otherwise it is not detected now)

---------

Co-authored-by: Tamotsu Takahashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake option GGML_OPENBLAS not working
2 participants