feat(EAP): Trace Item resolvers #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
force-pushed
the
volo/eap/event_resolvers
branch
from
3d283d7 to
07f5413
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
xurui-c
reviewed
Jan 9, 2025
Comment on lines
+36
to
+53
| class ResolverAttributeNames( | ||
| TraceItemDataResolver[ | ||
| TraceItemAttributeNamesRequest, TraceItemAttributeNamesResponse | ||
| ] | ||
| ): | ||
| @classmethod | ||
| def endpoint_name(cls) -> str: | ||
| return "AttributeNames" | ||
|
|
||
|
|
||
| class ResolverAttributeValues( | ||
| TraceItemDataResolver[ | ||
| TraceItemAttributeValuesRequest, TraceItemAttributeValuesResponse | ||
| ] | ||
| ): | ||
| @classmethod | ||
| def endpoint_name(cls) -> str: | ||
| return "AttributeValues" |
There was a problem hiding this comment.
Should we also implement resolvers for these in the future (subsequent PR)?
davidtsuk
reviewed
Jan 9, 2025
| ) -> "Type[TraceItemDataResolver[Tin, Tout]]": | ||
| return cast( | ||
| Type["TraceItemDataResolver[Tin, Tout]"], | ||
| getattr(cls, "_registry").get_class_from_name( |
There was a problem hiding this comment.
Maybe I'm missing something, but where is this _registry attribute being set?
There was a problem hiding this comment.
in the RegisteredClass metaclass
| return cast( | ||
| Type["TraceItemDataResolver[Tin, Tout]"], | ||
| getattr(cls, "_registry").get_class_from_name( | ||
| f"{cls.endpoint_name()}__{trace_item_name}" |
There was a problem hiding this comment.
From my understanding trace_item_name is an enum, so won't this evaluate to something like "TraceItemTable__0"?
volokluev
force-pushed
the
volo/eap/event_resolvers
branch
from
65806d1 to
d962e4e
Compare
xurui-c
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to make room for new kinds of TraceItems (e.g. uptime monitors, errors, logs, etc),add a layer of indirection to the RPC layer
Before:
After:
For rationale, please read this doc
How it works:
Every EAP endpoint has a
get_resolvermethod based on theTraceItemNamepassed in the request meta. A resolver has the same inputs and outputs as the RPCEndpoint.For each endpoint in EAP, there is a resolver class:
https://github.com/getsentry/snuba/pull/6732/files#diff-c018ef30d919d555c5e69908ce74e5f9144d613de3588a48d849f8c757b58628R22-R53
For each TraceItem we have, we implement the appropriate resolvers, this PR moves EndpointTraceItemTable and EndpointTimeSeries implementations for EAP spans into resolver implementations.
Resolvers are picked up automatically if they follow the directory structure:
Implementing resolver classes in these directories will ❇️ just work ❇️ without needing to change endpoint code.
Outstanding things
It's not clear yet what is really "common" and what is not. We will figure this out through the course of doing this work