Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uptime): rename snuba migration to correct number #6728

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

JoshFerge
Copy link
Member

renames the migration as 19 was reverted in the EAP dataset. #6697 (comment)

@JoshFerge JoshFerge requested review from a team as code owners January 8, 2025 19:04
@JoshFerge JoshFerge requested a review from phacops January 8, 2025 19:04
Copy link
Member

@colin-sentry colin-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already made migration 19 but I'll move mine to 20 now

@JoshFerge
Copy link
Member Author

I already made migration 19 but I'll move mine to 20 now

haha sounds like we may need a migration lockfile similar to the sentry postgres migrations :P wanna just keep yours at 19 if its gonna be merged imminently? i may not merge for an hour or until i get a re-review

@colin-sentry
Copy link
Member

no rush, my PR hasn't been reviewed yet

@JoshFerge JoshFerge enabled auto-merge (squash) January 8, 2025 19:17
@JoshFerge JoshFerge merged commit 0932e89 into master Jan 8, 2025
31 checks passed
@JoshFerge JoshFerge deleted the jferg/rename-migration branch January 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants