-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inc-984): Cleanup EAP spans #6676
Conversation
c1aaf45
to
4e3739f
Compare
ddd1acf
to
b44316a
Compare
b44316a
to
ebab5ff
Compare
on_cluster = f"ON CLUSTER '{cluster_name}'" if cluster_name else "" | ||
return f"""ALTER TABLE eap_spans_2_local | ||
{on_cluster} | ||
UPDATE `attr_str_1` = mapApply((k, v) -> (k, if(k = 'user.ip', 'scrubbed', v)), `attr_str_1`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the col name attr_str_1
in the end because https://clickhouse.com/docs/en/sql-reference/functions/tuple-map-functions#mapapply
|
||
@pytest.mark.clickhouse_db | ||
@pytest.mark.redis_db | ||
def test_span_is_scrubbed() -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the extra test i added
34c2d4c
to
c9dc10f
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
933137b
to
3f5df8e
Compare
3f5df8e
to
7a0d81a
Compare
7a0d81a
to
0a9d96b
Compare
9a2198b
to
a59126c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the print statement and we're good
9babab1
to
ffc90a1
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
doing #6673
differences:
StorageSetKey
test_span_is_scrubbed