Drop dist migrations first

getsentry · Jan 8, 2025 · 85d521c · 85d521c
1 parent 246e395
commit 85d521c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/snuba/snuba_migrations/events/0025_add_features_column.py b/snuba/snuba_migrations/events/0025_add_features_column.py
@@ -7,7 +7,7 @@
 from snuba.migrations.columns import MigrationModifiers as Modifiers
 from snuba.migrations.operations import OperationTarget
 
-table_names = [
+migration_meta = [
     ("errors_local", StorageSetKey.EVENTS, OperationTarget.LOCAL),
     ("errors_dist", StorageSetKey.EVENTS, OperationTarget.DISTRIBUTED),
     ("errors_dist_ro", StorageSetKey.EVENTS_RO, OperationTarget.DISTRIBUTED),
@@ -26,7 +26,7 @@ def backwards_ops(self) -> Sequence[operations.SqlOperation]:
 
 def forward_ops() -> Iterator[operations.SqlOperation]:
     # Add local and dist columns for the three tables.
-    for table_name, storage_set, target in table_names:
+    for table_name, storage_set, target in migration_meta:
         yield from [
             operations.AddColumn(
                 storage_set=storage_set,
@@ -72,7 +72,7 @@ def backward_ops() -> Iterator[operations.SqlOperation]:
         target=OperationTarget.LOCAL,
     )
 
-    for table_name, storage_set, target in table_names:
+    for table_name, storage_set, target in reversed(migration_meta):
         yield from [
             operations.DropColumn(
                 storage_set=storage_set,