Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): Actually use custom config #3459

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix(redis): Actually use custom config #3459

merged 3 commits into from
Dec 6, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 5, 2024

Follow up to #3427 (comment) where we created and mounted a custom Redis config only to not use it 🤦

Follow up to #3427 (comment) where we created and mounted a custom Redis config only to not use it 🤦
@BYK BYK requested review from aldy505 and hubertdeng123 December 5, 2024 14:43
@BYK BYK enabled auto-merge (squash) December 5, 2024 14:44
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@BYK BYK requested a review from hubertdeng123 December 5, 2024 20:49
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (e535c2b) to head (8d646fd).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3459   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit 3834ca7 into master Dec 6, 2024
14 checks passed
@BYK BYK deleted the byk/fix/redis-conf branch December 6, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants