Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandate minimum requirements for ram/cpu #3275

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

hubertdeng123
Copy link
Member

get rid of soft requirements for ram/cpu, enforce this as a hard requirement instead.
16 GB of ram, 4 CPU cores

@hubertdeng123 hubertdeng123 requested a review from a team August 16, 2024 21:35
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (9b56d62) to head (e9fdf53).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
+ Coverage   98.02%   99.01%   +0.98%     
==========================================
  Files           3        3              
  Lines         203      203              
==========================================
+ Hits          199      201       +2     
+ Misses          4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuarli joshuarli merged commit b6de547 into master Aug 17, 2024
14 checks passed
@joshuarli joshuarli deleted the hubertdeng123/mandate-minimum-cpu-ram-requirements branch August 17, 2024 19:26
@BYK
Copy link
Member

BYK commented Aug 18, 2024

Would be great to record the reasoning for this change somewhere

@lukasleitsch
Copy link

I'm using a server (Hetzner) with 16GB of RAM, but a few MB are missing. The install script fails with:

FAIL: Required minimum RAM available to Docker is 15900 MB, found 15611 MB

Would be great to decrease the limit a little bit.

@danilogco
Copy link

@joshuarli is it possible to reduce the limit? Just like @lukasleitsch, my instance hosted in AWS it's supposed to be 16GB of RAM, but it's a little below of the imposed limit. Well, I changed the file manually inside the EC2 to make it work.

@joshuarli
Copy link
Member

Yes, sorry. Thanks for the feedback! #3290

@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants