Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ref(feedback): cleanup topic rollout option" #3262

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Aug 12, 2024

Reverts #3256

Reverting to wait for the relay deploy (happening tomorrow). Plan to reopen in a few days, to account for potential reverts

@aliu39 aliu39 requested a review from a team August 12, 2024 18:33
@aliu39 aliu39 enabled auto-merge (squash) August 12, 2024 18:33
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (d64f72f) to head (e5dc517).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3262      +/-   ##
==========================================
- Coverage   98.02%   94.08%   -3.95%     
==========================================
  Files           3        3              
  Lines         203      203              
==========================================
- Hits          199      191       -8     
- Misses          4       12       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliu39 aliu39 merged commit 9b815ac into master Aug 12, 2024
13 of 14 checks passed
@aliu39 aliu39 deleted the revert-3256-aliu/cleanup-feedback-option branch August 12, 2024 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants